sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi… URL: https://github.com/apache/drill/pull/1459#discussion_r221490851
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/RuntimeFilterVisitor.java ########## @@ -223,16 +223,16 @@ public Void visitJoin(JoinPrel prel, RFHelperHolder holder) throws RuntimeExcept right.accept(this, holder); boolean routeToForeman = holder.needToRouteToForeman(); if (!routeToForeman) { - runtimeFilterDef.setSendToForeman(false); + runtimeFilterDef.setSendToForeman(!routeToForeman); } else { - runtimeFilterDef.setSendToForeman(true); + runtimeFilterDef.setSendToForeman(routeToForeman); } List<BloomFilterDef> bloomFilterDefs = runtimeFilterDef.getBloomFilterDefs(); for (BloomFilterDef bloomFilterDef : bloomFilterDefs) { if (!routeToForeman) { - bloomFilterDef.setLocal(true); + bloomFilterDef.setLocal(!routeToForeman); } else { - bloomFilterDef.setLocal(false); + bloomFilterDef.setLocal(routeToForeman); Review comment: Same here you can remove `if-else` block ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services