vvysotskyi commented on a change in pull request #1484: DRILL-6762: Fix dynamic
UDFs versioning issue
URL: https://github.com/apache/drill/pull/1484#discussion_r221584992
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
##########
@@ -76,15 +74,17 @@ public static PhysicalPlan getPlan(QueryContext context,
String sql) throws SqlP
* @param textPlan text plan
* @return query physical plan
*/
- public static PhysicalPlan getPlan(QueryContext context, String sql,
Pointer<String> textPlan)
- throws ForemanSetupException {
+ public static PhysicalPlan getPlan(QueryContext context, String sql,
Pointer<String> textPlan) throws ForemanSetupException {
Pointer<String> textPlanCopy = textPlan == null ? null : new
Pointer<>(textPlan.value);
try {
return getQueryPlan(context, sql, textPlan);
} catch (Exception e) {
+ logger.trace("Unable to find function in local function registry. " +
Review comment:
Is it possible that the exception here may appear for other cases except for
the case when the function wasn't found?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
