arina-ielchiieva commented on a change in pull request #1483: DRILL-3988: Expose Drill built-in functions & UDFs in a system table URL: https://github.com/apache/drill/pull/1483#discussion_r222601521
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/registry/FunctionRegistryHolder.java ########## @@ -97,9 +98,13 @@ // function name, Map<function signature, function holder> private final Map<String, Map<String, DrillFuncHolder>> functions; + // jar name, List<function holder> + private final Map<String, List<FunctionHolder>> jarFunctions; Review comment: I don't see any value of adding one more holder to keep functions. Current two holders have enough information and its unique. Your holder just duplicates it. Please consider approach i have suggested before. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
