HanumathRao commented on a change in pull request #1488: DRILL-786: Allow CROSS
JOIN syntax
URL: https://github.com/apache/drill/pull/1488#discussion_r222781427
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
##########
@@ -256,14 +255,6 @@ public SqlNode visit(SqlCall sqlCall) {
"See Apache Drill JIRA: DRILL-1986");
throw new UnsupportedOperationException();
}
-
- // Block Cross Join
- if(join.getJoinType() == JoinType.CROSS) {
Review comment:
Just to for the clarification is that for implicit cross joins and explicit
cross joins do we have joinType set to CROSS by the calcite. If not then can we
not distinguish them and only enable the explicit CROSS joins all the time??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
