Ben-Zvi commented on a change in pull request #1490: DRILL-6766: Lateral Unnest
query : IllegalStateException - rowId in right batch of lateral is smaller than
rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r222874733
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
##########
@@ -281,15 +288,15 @@ public IterOutcome innerNext() {
container.setRecordCount(recordCount);
logger.debug("Aggregator response {}, records {}", aggOutcome,
aggregator.getOutputCount());
// overwrite the outcome variable since we no longer need to remember the
first batch outcome
- lastKnownOutcome = aggregator.getOutcome();
+ IterOutcome returnOutcome = aggregator.getOutcome();
Review comment:
Need to modify the comment above this line; like explaining that
`lastKnownOutcome` is modified below if needed and as needed, depends on the
`aggOutcome` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
