gparai commented on a change in pull request #1489: DRILL-6770:
JsonTableGroupScan should use new MapRDB 6.1.0 APIs
URL: https://github.com/apache/drill/pull/1489#discussion_r223052988
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/JsonTableGroupScan.java
##########
@@ -184,11 +184,9 @@ public MapRDBSubScan getSpecificScan(int minorFragmentId)
{
@Override
public ScanStats getScanStats() {
- //TODO: look at stats for this.
- long rowCount = (long) ((scanSpec.getSerializedFilter() != null ? .5 : 1)
* totalRowCount);
Review comment:
The totalrowcount already factored in the scanspec condition - please see
the metatable call above. This was a bug in changes made for DRILL-5429. I
missed it while reviewing the PR. The original rowcount did not factor the
condition earlier hence it was estimating it here based on whether the filter
is present or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
