lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-427734567 @vvysotskyi thanks for your comments. Changes are made as you suggested. As you mentioned early, some tests are made to test this functionality: Both jdk and janio compiler works fine. Constants with different types(string, double, long, decimal, time, timestamp and so on) are tested. But some tests beside the Travis are not passed, a lot of `No default schema selected` errors occured, it seems that these errors are not connected to this change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services