arina-ielchiieva commented on a change in pull request #1494: DRILL-6768:
Improve to_date, to_time and to_timestamp and correspondi…
URL: https://github.com/apache/drill/pull/1494#discussion_r223314016
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
##########
@@ -131,7 +131,7 @@
new
OptionDefinition(ExecConstants.HASHAGG_MIN_BATCHES_PER_PARTITION_VALIDATOR), //
for tuning
new
OptionDefinition(ExecConstants.HASHAGG_USE_MEMORY_PREDICTION_VALIDATOR), // for
testing
new OptionDefinition(ExecConstants.HASHAGG_FALLBACK_ENABLED_VALIDATOR),
// for enable/disable unbounded HashAgg
- new OptionDefinition(ExecConstants.CAST_TO_NULLABLE_NUMERIC_OPTION),
+ new OptionDefinition(ExecConstants.CAST_EMPTY_STRING_TO_NULL_OPTION),
Review comment:
Options are considered as part of API, do not remove them, mark as
deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
