vdiravka commented on a change in pull request #1466: DRILL-6381: Add support
for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r223648507
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBFormatPlugin.java
##########
@@ -57,34 +64,74 @@ public MapRDBFormatPlugin(String name, DrillbitContext
context, Configuration fs
hbaseConf = HBaseConfiguration.create(fsConf);
hbaseConf.set(ConnectionFactory.DEFAULT_DB,
ConnectionFactory.MAPR_ENGINE2);
connection = ConnectionFactory.createConnection(hbaseConf);
+ jsonTableCache = new MapRDBTableCache(context.getConfig());
+ int scanRangeSizeMBConfig =
context.getConfig().getInt(PluginConstants.JSON_TABLE_SCAN_SIZE_MB);
+ if (scanRangeSizeMBConfig < 32 || scanRangeSizeMBConfig > 8192) {
Review comment:
These are magic numbers. Please create constant field or local values for 32
and 8192 (If they doesn't exist in MapR-DB libs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
