vdiravka commented on a change in pull request #1466: DRILL-6381: Add support 
for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r223683219
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillMergeProjectRule.java
 ##########
 @@ -166,4 +169,25 @@ public void onMatch(RelOptRuleCall call) {
     return list;
   }
 
+  public static Project replace(Project topProject, Project bottomProject) {
 
 Review comment:
   Can `ProjectAllowDup` and `Project` rels be merged?
   For instance:
   `00-01      ProjectAllowDup(MONTHID=[$0], NOFOCONTRACTS=[$1]) : rowType = 
RecordType(INTEGER MONTHID, INTEGER NOFOCONTRACTS)`
   `00-02        Project(MonthId=[CAST($1):INTEGER], No of 
Contracts=[CAST($2):INTEGER]) : rowType = RecordType(INTEGER MonthId, INTEGER 
No of Contracts)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to