sachouche commented on a change in pull request #1497: DRILL-6410: Fixed memory
leak in flat Parquet reader
URL: https://github.com/apache/drill/pull/1497#discussion_r223762506
##########
File path: exec/jdbc-all/pom.xml
##########
@@ -511,7 +511,7 @@
This is likely due to you adding new dependencies to a
java-exec and not updating the excludes in this module. This is important as it
minimizes the size of the dependency of Drill application users.
</message>
- <maxsize>39000000</maxsize>
+ <maxsize>39500000</maxsize>
Review comment:
@vvysotskyi,
- I rebased several times and didn't see the fix; saw it only after
publishing the PR
- Talked internally to the team and was advised to update the pom
BTW - The current way of packaging the jdbc-all jar is unsustainable (unless
we accept the fact this jar might indefinitely increase in size). The right
fix, is to divide the java-exec project into multiple projects: common, client,
and server. This way, the jdbc-all artifact should only depend on common and
client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
