vdiravka commented on a change in pull request #1466: DRILL-6381: Add support
for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224127034
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
##########
@@ -517,6 +388,15 @@ private static FieldPath
getFieldPathForProjection(SchemaPath column) {
return new FieldPath(child);
}
+ public static boolean includesIdField(Collection<FieldPath> projected) {
+ return Iterables.tryFind(projected, new Predicate<FieldPath>() {
Review comment:
Sure. Guava Predicate has a javadoc with a reference to:
https://github.com/google/guava/wiki/FunctionalExplained
> While Guava's functional utilities are usable on Java versions prior to
Java 8, functional programming without Java 8 requires awkward and verbose use
of anonymous classes.
Personally I think it looks better also my IDE sometimes suggest me how it
is possible to convert old code style to java8.
```
return Iterables.tryFind(projected, path ->
Preconditions.checkNotNull(path).equals(ID_FIELD))
.isPresent();
```
Also here `FieldPath` could be null and NPE as a result. Is it expected? If
no, to avoid it you can use `Objects.equals()` instead of
`reconditions.checkNotNull()` and usual `Object.equals()` (_Note_: Objects vs
Object).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
