parthchandra commented on a change in pull request #1490: DRILL-6766: Lateral
Unnest query : IllegalStateException - rowId in right batch of lateral is
smaller than rowId in left batch being processed
URL: https://github.com/apache/drill/pull/1490#discussion_r224170040
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggTemplate.java
##########
@@ -405,16 +414,16 @@ private final void incIndex() {
}
private final void resetIndex() {
- underlyingIndex = -1;
- incIndex();
+ underlyingIndex = 0;
Review comment:
Are you sure this is correct? incIndex() increments underlyingIndex and then
calls getVectorIndex(underlyingIndex).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services