vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-428920593 @lushuifeng, then this change will break code compilation for the case when a lot of constants were used. Previously, these constants were separated between the outer and nested classes. But with these changes, additional items in the class constant pool will be used for setter methods[1], and in the outer class will be present all setters, so it will cause the overflow of the class constant pool. [1] https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.6
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
