arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show 
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224740139
 
 

 ##########
 File path: exec/java-exec/src/main/resources/ace.mode-sql.template.js
 ##########
 @@ -0,0 +1,121 @@
+/**
 
 Review comment:
   1. I suggest we keep js scripts / templates under one folder.
   Could you please move it rest/static/js folder?
   Also could you please do the same for options.dscribe.template.js
   
   2. mode-sql.js has the same code, please factor out the same parts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to