amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224926241
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBPushFilterIntoScan.java
##########
@@ -137,11 +137,10 @@ protected void
doPushFilterIntoJsonGroupScan(RelOptRuleCall call,
return; //no filter pushdown ==> No transformation.
}
- // clone the groupScan with the newScanSpec.
- final JsonTableGroupScan newGroupsScan = groupScan.clone(newScanSpec);
+ final JsonTableGroupScan newGroupsScan = (JsonTableGroupScan)
groupScan.clone(newScanSpec);
Review comment:
Currently, the `clone()` method returns an instance of `GroupScan`, so this
cast is needed. Did you mean change the original `clone` implementation itself
? That will require some additional changes since both binary table and json
table implement it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
