kkhatua commented on a change in pull request #1507: DRILL-6715: Update descriptions for System Options table URL: https://github.com/apache/drill/pull/1507#discussion_r226727453
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassTransformer.java ########## @@ -61,7 +62,10 @@ public final static String SCALAR_REPLACEMENT_OPTION = "org.apache.drill.exec.compile.ClassTransformer.scalar_replacement"; public final static EnumeratedStringValidator SCALAR_REPLACEMENT_VALIDATOR = new EnumeratedStringValidator( - SCALAR_REPLACEMENT_OPTION, null, "try", "off", "try", "on"); + SCALAR_REPLACEMENT_OPTION, Review comment: I agree. I'm not sure why the choice of putting it here was made. I'll move it into ExecConstants. All the settings I've seen reside in `ExecConstants` and `PlannerSettings`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services