arina-ielchiieva commented on a change in pull request #1509: DRILL-6810: 
Disable NULL_IF_NULL NullHandling for functions with Comp…
URL: https://github.com/apache/drill/pull/1509#discussion_r227330995
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java
 ##########
 @@ -138,6 +138,9 @@
      * Indicates that a method's associated logical operation returns NULL if
      * either input is NULL, and therefore that the method must not be called
      * with null inputs.  (The calling framework must handle NULLs.)
+     *
+     * <p>Not Supported for Functions with {@link Output} of type
+     * {@link 
org.apache.drill.exec.vector.complex.writer.BaseWriter.ComplexWriter}.</p>
 
 Review comment:
   Aggregate functions are also no supported for this type of null handling 
strategy. Could you please mention this point as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to