KazydubB commented on a change in pull request #1509: DRILL-6810: Disable
NULL_IF_NULL NullHandling for functions with Comp…
URL: https://github.com/apache/drill/pull/1509#discussion_r228150152
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillAggFuncHolder.java
##########
@@ -65,7 +65,12 @@ public DrillAggFuncHolder(
FunctionAttributes attributes,
FunctionInitializer initializer) {
super(attributes, initializer);
- checkArgument(attributes.getNullHandling() == NullHandling.INTERNAL, "An
aggregation function is required to do its own null handling.");
+ }
+
+ @Override
+ protected void checkNullHandling(NullHandling nullHandling) {
Review comment:
1. Moved here and in `DrillComplexWriterFuncHolder.java`. Not sure if needed
to be moved in `DrillFuncHolder.java` as the method appears after public
constructor which invokes it. Should I move there as well?
2. Changed to "...is required to handle null input(s) on its own."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
