sohami commented on a change in pull request #1504: DRILL-6792: Find the right
probe side fragment wrapper & fix DrillBuf…
URL: https://github.com/apache/drill/pull/1504#discussion_r229763641
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -1222,7 +1222,7 @@ public HashJoinBatch(HashJoinPOP popConfig,
FragmentContext context,
RecordBatchStats.logRecordBatchStats(getRecordBatchStatsContext(),
"configured output batch size: %d", configuredBatchSize);
- enableRuntimeFilter =
context.getOptions().getOption(ExecConstants.HASHJOIN_ENABLE_RUNTIME_FILTER);
+ enableRuntimeFilter =
context.getOptions().getOption(ExecConstants.HASHJOIN_ENABLE_RUNTIME_FILTER) &&
popConfig.getRuntimeFilterDef() != null;
Review comment:
Is this an error condition when the feature is `enabled` but
`runtimeFilterDef` is not present in popConfig ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
