bitblender commented on a change in pull request #1467: DRILL-5671: Set secure ACLs (Access Control List) for Drill ZK nodes in a secure cluster URL: https://github.com/apache/drill/pull/1467#discussion_r230403743
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKACLProviderFactory.java ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.coord.zk; + +import org.apache.drill.common.config.DrillConfig; +import static org.apache.drill.exec.ExecConstants.ZK_ACL_PROVIDER; +import static org.apache.drill.exec.ExecConstants.ZK_APPLY_SECURE_ACL; + +import org.apache.drill.common.scanner.persistence.ScanResult; +import org.apache.drill.exec.exception.DrillbitStartupException; +import org.apache.drill.exec.server.BootStrapContext; +import org.apache.drill.shaded.guava.com.google.common.base.Strings; +import java.lang.reflect.InvocationTargetException; + +import java.lang.reflect.Constructor; +import java.util.Collection; + +/** + * This function returns a {@link ZKACLProviderDelegate} which will be used to set ACLs on Drill ZK nodes + * If secure ACLs are required, the {@link ZKACLProviderFactory} looks up and instantiates a {@link ZKACLProviderDelegate} + * specified in the config file. Else it returns the {@link ZKDefaultACLProvider} + */ +public class ZKACLProviderFactory { + + static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(ZKACLProviderFactory.class); Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
