paul-rogers commented on a change in pull request #1450: DRILL-6717: lower and
upper functions not works with national characters
URL: https://github.com/apache/drill/pull/1450#discussion_r231004879
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
##########
@@ -786,10 +784,11 @@ public void setup() {
@Override
public void eval() {
- out.buffer = buffer = buffer.reallocIfNeeded(input.end - input.start);
+ byte[] result =
org.apache.drill.exec.expr.fn.impl.StringFunctionHelpers.initCap(input.start,
input.end, input.buffer);
Review comment:
The earlier functions handle the DrillBuf to string conversion and the
String to byte[] conversion. Might want to do that here, changing the initCap()
method to:
```
String initCap(String input)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
