Ben-Zvi commented on a change in pull request #1522: Drill 6735: Implement
Semi-Join for the Hash-Join operator
URL: https://github.com/apache/drill/pull/1522#discussion_r233216894
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -998,6 +1000,10 @@ public IterOutcome executeBuildPhase() throws
SchemaChangeException {
: read_right_HV_vector.getAccessor().get(ind); // get the hash
value from the HV column
int currPart = hashCode & spilledState.getPartitionMask();
hashCode >>>= spilledState.getBitsInMask();
+ // semi-join skips join-key-duplicate rows
+ if ( semiJoin ) {
+
Review comment:
Thanks. That empty if was a reminder for the followup work on the duplicate
elimination; maybe we should leave it there as a reminder (it would be
overwritten when the 2nd and 3rd commit would be added).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
