vvysotskyi commented on issue #1524: DRILL-6830: Remove Hook.REL_BUILDER_SIMPLIFY handler after use URL: https://github.com/apache/drill/pull/1524#issuecomment-438724649 @lushuifeng, you are right that the problem connected with `TestCaseNullableTypes#testCaseNullableTypesVarchar` is in Calcite. The initial goal for adding `Hook.REL_BUILDER_SIMPLIFY.add(Hook.propertyJ(false));` was to avoid failures connected with treating empty strings as null feature, but looks like it was fixed in another place. The interesting thing is that problem connected with `TestCaseNullableTypes#testCaseNullableTypesVarchar` failure was fixed after 1.17 version, so when Drill is rebased onto Calcite 1.18, `Hook.REL_BUILDER_SIMPLIFY.add(Hook.propertyJ(false));` may be removed. @ihuzenko, since you are working on Calcite rebase, could you please also take care of it?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
