arina-ielchiieva commented on a change in pull request #1543: DRILL-6668: In
Web UI, highlight options that are not default values
URL: https://github.com/apache/drill/pull/1543#discussion_r233951213
##########
File path: exec/java-exec/src/main/resources/rest/options.ftl
##########
@@ -84,7 +104,9 @@ table.sortable thead .sorting_desc { background-image:
url("/static/img/black-de
<input type="text" class="form-control"
placeholder="${option.getValueAsString()}" name="value"
value="${option.getValueAsString()}">
</#if>
<div class="input-group-btn">
- <button class="btn btn-default"
type="submit">Update</button>
+ <button class="btn btn-default" type="button"
onclick="alterSysOptionUsingId('${option.getName()}')">Update</button>
+ <button class="btn btn-default" type="button"
onclick="alterSysOption('${option.getName()}','${option.getDefaultValueAsString()}',
'${option.getKind()}')" <#if option.getDefaultValueAsString() ==
option.getValueAsString()>disabled="true" style="pointer-events:none" <#else>
+ title="Reset to
${option.getDefaultValueAsString()}"</#if>>Default</button>
Review comment:
Maybe better rename button to Reset?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
