kkhatua commented on a change in pull request #1543: DRILL-6668: In Web UI,
highlight options that are not default values
URL: https://github.com/apache/drill/pull/1543#discussion_r233965178
##########
File path: exec/java-exec/src/main/resources/rest/options.ftl
##########
@@ -21,6 +21,26 @@
<#macro page_head>
<script type="text/javascript" language="javascript"
src="/static/js/jquery.dataTables-1.10.16.min.js"> </script>
<script type="text/javascript" language="javascript"
src="/static/js/dataTables.colVis-1.1.0.min.js"></script>
+ <script>
+ //Alter System Values
+ function alterSysOption(optionName, optionValue, optionKind) {
+ $.post("/option/"+optionName, {kind: optionKind, name: optionName,
value: optionValue}, function () {
+ location.reload(true);
+ });
+ }
+
+ //Read Values and apply
+ function alterSysOptionUsingId(optionRawName) {
Review comment:
It does make the changes a little more complex, but the primary motivation
was that the same code path is being exercised for making any changes to the
options. It's also why I kept it as 2 commits. We can revert it if we don't
want a common execution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
