kkhatua commented on a change in pull request #1536: DRILL-6039: Fixed
drillbit.sh script to do graceful shutdown
URL: https://github.com/apache/drill/pull/1536#discussion_r235139192
##########
File path: distribution/src/resources/drillbit.sh
##########
@@ -94,11 +94,24 @@ waitForProcessEnd()
commandName=$2
kill_drillbit=$3
processedAt=`date +%s`
+ triggered_shutdown=false
+ FILE=$DRILL_PID_DIR/.graceful
origcnt=${DRILL_STOP_TIMEOUT:-120}
while kill -0 $pidKilled > /dev/null 2>&1;
do
echo -n "."
sleep 1;
+ #Incase of graceful shutdown, create .graceful file and wait till it is
deleted to trigger kill command.
+ if [ "$kill_drillbit" = false ]; then
+ if [ "$triggered_shutdown" = false ]; then
+ touch $DRILL_PID_DIR/.graceful
+ triggered_shutdown=true
+ else
+ if [ ! -f "$FILE" ]; then
+ kill $pidKilled > /dev/null 2>&1;
Review comment:
@sohami I think she is just playing it safe by doing a clean up.
A suggestion... for all the `kill` commands, provide the signal as part of
the arguments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
