sohami commented on a change in pull request #1536: DRILL-6039: Fixed drillbit.sh script to do graceful shutdown URL: https://github.com/apache/drill/pull/1536#discussion_r235488412
########## File path: distribution/src/resources/drillbit.sh ########## @@ -192,6 +201,10 @@ start_bit ( ) echo $procId > $pidFile # Yeah, $pidFile is a file, $procId is the pid... echo $! > $pidFile sleep 1 + #remove any previous uncleaned graceful file + if [ -f "$GRACEFUL_FILE" ]; then + rm $GRACEFUL_FILE Review comment: we should check for error while removing the graceful file and if it fails then echo an error message and exit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
