sohami commented on a change in pull request #1504: DRILL-6792: Find the right
probe side fragment wrapper & fix DrillBuf…
URL: https://github.com/apache/drill/pull/1504#discussion_r236405542
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterSink.java
##########
@@ -74,32 +70,43 @@
private SendingAccountor sendingAccountor;
+ private AsyncAggregateWorker asyncAggregateWorker;
+
+ private AtomicBoolean running = new AtomicBoolean(true);
+
private static final Logger logger =
LoggerFactory.getLogger(RuntimeFilterSink.class);
public RuntimeFilterSink(DrillbitContext drillbitContext, SendingAccountor
sendingAccountor)
{
this.drillbitContext = drillbitContext;
this.sendingAccountor = sendingAccountor;
- AsyncAggregateWorker asyncAggregateWorker = new AsyncAggregateWorker();
- drillbitContext.getExecutor().submit(asyncAggregateWorker);
}
public void add(RuntimeFilterWritable runtimeFilterWritable)
{
+ if (asyncAggregateWorker == null) {
+ asyncAggregateWorker = new AsyncAggregateWorker();
+ drillbitContext.getExecutor().submit(asyncAggregateWorker);
+ }
Review comment:
Should be done once in constructor. Putting here has issues such that
multiple netty threads can create multiple `asyncAggregateWorker` thread and
leak all except the last set one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
