arina-ielchiieva commented on a change in pull request #1557: DRILL-6863: Drop
table is not working if path within workspace starts…
URL: https://github.com/apache/drill/pull/1557#discussion_r237463961
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
##########
@@ -56,7 +57,7 @@ public DropTableHandler(SqlHandlerConfig config) {
@Override
public PhysicalPlan getPlan(SqlNode sqlNode) throws ValidationException,
RelConversionException, IOException {
SqlDropTable dropTableNode = ((SqlDropTable) sqlNode);
- String originalTableName = dropTableNode.getName();
+ String originalTableName =
FileSelection.removeLeadingSlash(dropTableNode.getName());
Review comment:
Maybe instead of removing slashes we should disallow creating such tables?
Let's say if we detect that table starts with slash fail and report any error
and table naming recommendations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
