vdiravka commented on a change in pull request #1561: DRILL-6751: Upgrade
Apache parent POM to version 21
URL: https://github.com/apache/drill/pull/1561#discussion_r239298502
##########
File path: pom.xml
##########
@@ -1679,28 +1681,20 @@
<algorithms>
<algorithm>SHA-512</algorithm>
</algorithms>
- <failOnError>false</failOnError>
+ <csvSummary>false</csvSummary>
</configuration>
</plugin>
- <!-- override the parent assembly execution to customize the assembly
- descriptor and final name -->
+
+ <!-- override the parent assembly execution to customize the
assembly final name -->
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
+ <version>3.1.0</version>
<executions>
<execution>
<id>source-release-assembly</id>
- <phase>package</phase>
- <goals>
- <goal>single</goal>
- </goals>
<configuration>
- <runOnlyAtExecutionRoot>true</runOnlyAtExecutionRoot>
<appendAssemblyId>false</appendAssemblyId>
- <descriptors>
-
<descriptor>src/main/resources/assemblies/source-assembly.xml</descriptor>
Review comment:
I have manually checked that all files are the same which obtained in the
result of `mvn clean install -DskipTests -Papache-release`.
Looks like there are no differences, except those mentioned in Laurent's
comment in the PR #449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
