gparai commented on a change in pull request #1568: DRILL-6878: Use
DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for
DrillSemiJoin
URL: https://github.com/apache/drill/pull/1568#discussion_r240471514
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillJoinRel.java
##########
@@ -45,6 +46,7 @@
*/
public class DrillJoinRel extends DrillJoinRelBase implements DrillRel {
public static final String EQUALITY_CONDITION = "==";
+ boolean isSemiJoin;
Review comment:
@amansinha100 earlier this flag was in RowKeyJoinRel. Later I moved it to
emulate the JoinPrel. However, since we have two logical rels (DrillJoinRel,
DrillSemiJoinRel) but only one physical rel base class (JoinPrel) it makes more
sense to move it to RowKeyJoinRel.
I have made the change. Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
