amansinha100 commented on a change in pull request #1568: DRILL-6878: Use
DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for
DrillSemiJoin
URL: https://github.com/apache/drill/pull/1568#discussion_r240511260
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillJoinRelBase.java
##########
@@ -209,4 +210,36 @@ public static RelOptCost
computeHashJoinCostWithRowCntKeySize(RelOptPlanner plan
return costFactory.makeCost(buildRowCount + probeRowCount, cpuCost, 0, 0,
memCost);
}
+ @Override public boolean isValid(Litmus litmus, Context context) {
Review comment:
I think this row type validation could be moved to the `RowKeyJoinRel`.
Doing this in the base class of the joins does not seem right considering the
Calcite is already doing the check for SemiJoin in its `isValid()`
implementation,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
