arina-ielchiieva commented on a change in pull request #1572: DRILL-6879: Show
warnings for potential performance issues
URL: https://github.com/apache/drill/pull/1572#discussion_r241387701
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
##########
@@ -56,8 +55,29 @@
private final CoreOperatorType operatorType;
private final String operatorName;
private final int size;
+ private static AtomicBoolean initializedWarningThreshold = new
AtomicBoolean();
+ private static int timeSkewMin;
+ private static double timeSkewRatio;
+ private static int scanWaitMin;
+ private static double waitSkewRatio;
+
+ //One time server setting for setting threshold warnings
+ static void setWarningThresholds(DrillConfig config) {
Review comment:
Please to do use static, do assignment as for regular class variables.
Currently DrillConfig does not change but this might change (and even if not),
statics is not the best way / practice here plus you accept DrillConfig in the
constructor which already implicates you use it for class variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
