kkhatua commented on a change in pull request #1572: DRILL-6879: Show warnings
for potential performance issues
URL: https://github.com/apache/drill/pull/1572#discussion_r241532388
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
##########
@@ -258,6 +258,11 @@ public String getExecutionDuration() {
return NOT_AVAILABLE_LABEL;
}
+ //Threshold to be used by WebServer in issuing warning
+ public String getNoProgressWarningThreshold() {
+ return String.valueOf(FragmentWrapper.getProgressWarningThreshold());
Review comment:
In this case, I can capture the value directly from the DrillConfig.
The reason I originally picked a static variable is because the value will
not change in the `DrillConfig` object (since it is read from
`drill-override.conf`). So, I want to read the value only initially and
thereafter reuse that without making calls to DrillConfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
