ihuzenko commented on a change in pull request #1559: DRILL-540: Allow querying
hive views in Drill
URL: https://github.com/apache/drill/pull/1559#discussion_r242476827
##########
File path:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/TestStorageBasedHiveAuthorization.java
##########
@@ -251,123 +322,304 @@ public void showSchemas() throws Exception {
}
/**
- * "SHOW TABLE" output for a db, should only contain the tables that the user
- * has access to read. If the user has no read access to the db, the list
will be always empty even if the user has
- * read access to the tables inside the db.
+ * Should only contain the tables that the user
+ * has access to read.
+ *
* @throws Exception
*/
@Test
- public void showTablesUser0() throws Exception {
+ public void user0_db_general_showTables() throws Exception {
updateClient(org1Users[0]);
+ showTablesHelper(db_general, ImmutableList.of(
+ g_student_u0_700,
+ g_student_u0g0_750,
+ g_student_all_755,
+ g_voter_all_755,
+ g_partitioned_student_u0_700,
+ g_vw_g_student_u0_700
+ ));
+ }
- showTablesHelper(db_general,
- ImmutableList.of(
- g_student_u0_700,
- g_student_u0g0_750,
- g_student_all_755,
- g_voter_all_755,
- g_partitioned_student_u0_700
- ));
-
- showTablesHelper(db_u0_only,
- ImmutableList.of(
- u0_student_all_755,
- u0_voter_all_755
- ));
-
- showTablesHelper(db_u1g1_only, Collections.<String>emptyList());
+ @Test
+ public void user0_db_u0_only_showTables() throws Exception {
+ updateClient(org1Users[0]);
+ showTablesHelper(db_u0_only, ImmutableList.of(
+ u0_student_all_755,
+ u0_voter_all_755,
+ u0_vw_voter_all_755
+ ));
}
+ /**
+ * If the user has no read access to the db, the list will be always empty
even if the user has
+ * read access to the tables inside the db.
+ *
+ * @throws Exception
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
