vvysotskyi commented on a change in pull request #1586: DRILL-6929: Exclude
maprfs jar for default profile
URL: https://github.com/apache/drill/pull/1586#discussion_r244200475
##########
File path:
contrib/storage-hive/core/scrMapr/main/java/org/apache/drill/exec/planner/sql/logical/ConvertHiveMapRDBJsonScanToDrillMapRDBJsonScan.java
##########
@@ -110,15 +100,15 @@ Hive does not always give correct costing (i.e. for
external tables Hive does no
To ensure Drill MapR-DB Json scan will be chosen, reduce Hive scan
importance to 0.
*/
call.getPlanner().setImportance(hiveScanRel, 0.0);
- } catch (final Exception e) {
+ } catch (RuntimeException e) {
Review comment:
There are some places where exception may be thrown and wrapped into
`DrillRuntimeException`, for example when a connection wasn't created during
instantiating `MapRDBFormatPlugin`, `DrillRuntimeException` will be thrown from
`HiveStoragePlugin.getFormatPlugin()`, so they will be catched there.
I have replaced `RuntimeException` with `DrillRuntimeException`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
