sohami commented on a change in pull request #1591: DRILL-6933: Fix ctrl+enter when Impersonation is disabled URL: https://github.com/apache/drill/pull/1591#discussion_r244909435
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java ########## @@ -60,7 +60,7 @@ private final HashMap<String, Long> majorFragmentTallyMap; private final long majorFragmentTallyTotal; private final OptionList options; - private final boolean onlyImpersonationEnabled; + private final boolean isOnlyImpersonationEnabled; Review comment: usually the convention is that boolean variable name should not start with `"is"`, it's the getter function which should have that. Variable name should only be `onlyImpersonationEnabled`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
