sohami commented on a change in pull request #1593: DRILL-6050: Provide a limit
to number of rows fetched for a query in UI
URL: https://github.com/apache/drill/pull/1593#discussion_r245455994
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -225,9 +225,9 @@ private ExecConstants() {
public static final String HTTP_SPNEGO_PRINCIPAL =
"drill.exec.http.auth.spnego.principal";
public static final String HTTP_SPNEGO_KEYTAB =
"drill.exec.http.auth.spnego.keytab";
//Control Web UI Resultset
- public static final String HTTP_WEB_CLIENT_RESULTSET_AUTOLIMIT_ENABLE =
"drill.exec.http.web.client.resultset.autolimit.enable";
+ public static final String HTTP_WEB_CLIENT_RESULTSET_AUTOLIMIT_CHECKED =
"drill.exec.http.web.client.resultset.autolimit.checked";
public static final String HTTP_WEB_CLIENT_RESULTSET_AUTOLIMIT_ROWS =
"drill.exec.http.web.client.resultset.autolimit.rows";
- public static final String HTTP_WEB_CLIENT_RESULTSET_DEFAULTROWSPERPAGE =
"drill.exec.http.web.client.resultset.defaultRowsPerPage";
+ public static final String HTTP_WEB_CLIENT_RESULTSET_ROWS_PER_PAGE =
"drill.exec.http.web.client.resultset.rowsPerPage";
Review comment:
This parameter now represents all the options for rows per page not a single
value so consider naming it `rowsPerPageOptions` / `rowsPerPageValues`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
