Ben-Zvi commented on a change in pull request #1598: DRILL-6880: For Hash-Join
hash-table build - treat null keys as an equal match
URL: https://github.com/apache/drill/pull/1598#discussion_r245769369
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java
##########
@@ -235,9 +246,14 @@ public HashTable createAndSetupHashTable(TypedFieldId[]
outKeyFieldIds) throws C
private void setupIsKeyMatchInternal(ClassGenerator<HashTable> cg,
MappingSet incomingMapping, MappingSet htableMapping,
LogicalExpression[] keyExprs, List<Comparator> comparators,
TypedFieldId[] htKeyFieldIds) {
+
+ boolean isProbe = incomingMapping == KeyMatchIncomingProbeMapping;
Review comment:
The initial implementation did use flags, but looked a little ugly with
"true" and "false" parameters in each call. I'll try and create an enum to make
it cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
