arina-ielchiieva commented on a change in pull request #1613: DRILL-6977:
Improve Hive tests configuration
URL: https://github.com/apache/drill/pull/1613#discussion_r248238029
##########
File path:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/HiveTestBase.java
##########
@@ -17,28 +17,43 @@
*/
package org.apache.drill.exec.hive;
+import org.apache.commons.io.FileUtils;
import org.apache.drill.PlanTestBase;
import org.apache.drill.exec.store.hive.HiveTestDataGenerator;
+import org.apache.drill.test.BaseDirTestWatcher;
import org.junit.AfterClass;
import org.junit.BeforeClass;
+import org.junit.runner.Description;
/**
* Base class for Hive test. Takes care of generating and adding Hive test
plugin before tests and deleting the
* plugin after tests.
*/
public class HiveTestBase extends PlanTestBase {
- protected static HiveTestDataGenerator hiveTest;
+
+ public static HiveTestConfig hiveTestConf;
Review comment:
final? Please use constant naming convention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
