vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r244850744
########## File path: contrib/format-syslog/README.md ########## @@ -0,0 +1,41 @@ +# Syslog Format Plugin Review comment: Good documentation. Some notes regarding your previous `Logfile Plugin` plugin (DRILL-6104): * Could you please add the clarification about type of Plugin to ` /exec/java-exec/src/main/java/org/apache/drill/exec/store/log/README.md` header: `# Drill Regex/Logfile Plugin` -> `# Drill Regex/Logfile Format Plugin` * Should `LogFormatPlugin` be considered to be moved to `contrib` package too, similar to `SyslogFormatPlugin`? No changes should be added in this PR. Just create a new Jira for it, if you agree with above notes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
