HanumathRao commented on issue #1620: DRILL-6997: Semijoin is changing the join ordering for some tpcds que… URL: https://github.com/apache/drill/pull/1620#issuecomment-457802682 @amansinha100 Thank you for the review. I have addressed the review comments. Regarding the multi column predicate testing for semi-join this test case is already added in the previous checkin. It produces the semi-join plan. I have not checked for the correctness of the result in the test case because this is having an issue when assertions are enabled in the runtime code. I will talk to @Ben-Zvi and open an issue. However, I have checked for the correctness manually and it does produce correct rows.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
