paul-rogers commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r251219067
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/file/FileMetadataManager.java ########## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.physical.impl.scan.file; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; + +import org.apache.directory.api.util.Strings; +import org.apache.drill.common.map.CaseInsensitiveMap; +import org.apache.drill.exec.ExecConstants; +import org.apache.drill.exec.physical.impl.scan.project.ColumnProjection; +import org.apache.drill.exec.physical.impl.scan.project.ConstantColumnLoader; +import org.apache.drill.exec.physical.impl.scan.project.MetadataManager; +import org.apache.drill.exec.physical.impl.scan.project.ResolvedTuple; +import org.apache.drill.exec.physical.impl.scan.project.ScanLevelProjection.ScanProjectionParser; +import org.apache.drill.exec.physical.impl.scan.project.SchemaLevelProjection.SchemaProjectionResolver; +import org.apache.drill.exec.physical.impl.scan.project.VectorSource; +import org.apache.drill.exec.physical.rowSet.ResultVectorCache; +import org.apache.drill.exec.record.VectorContainer; +import org.apache.drill.exec.record.metadata.TupleMetadata; +import org.apache.drill.exec.server.options.OptionSet; +import org.apache.drill.exec.store.ColumnExplorer.ImplicitFileColumns; +import org.apache.drill.exec.vector.ValueVector; +import org.apache.hadoop.fs.Path; + +import org.apache.drill.shaded.guava.com.google.common.annotations.VisibleForTesting; + +public class FileMetadataManager implements MetadataManager, SchemaProjectionResolver, VectorSource { + + // Input + + private Path scanRootDir; + private FileMetadata currentFile; + + // Config + + protected final String partitionDesignator; + protected List<FileMetadataColumnDefn> implicitColDefns = new ArrayList<>(); + protected Map<String, FileMetadataColumnDefn> fileMetadataColIndex = CaseInsensitiveMap.newHashMap(); + protected boolean useLegacyWildcardExpansion = true; Review comment: This is an area where some help would be handy. What semantics did we end up using? In one version, if we had "SELECT *" in a table with columns a, b, c, we ended up with a batch with vectors in the order: a, b, c, fqn, filename, dir0, dir1, ... Later, we changed it to this format, which is unstable: fqn, filename, dir0, dir1, ..., a, b, c Since the number of "dir" columns changes between files, the locations of all the table columns changed in the vector, which is a nuisance. I can did in to figure this out, but if someone knows how things work today, it would save me a bit of time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
