kkhatua commented on issue #1608: DRILL-6960: AutoLimit the size of ResultSet for a WebUI (or REST) client URL: https://github.com/apache/drill/pull/1608#issuecomment-461889067 **DRILL-6960: AutoLimit the size of ResultSet for a WebUI (or REST) client** 1. Check if username (if impersonation is enabled) and limits are valid inputs 2. Switch `help` from onclick to a hovering tooltip 3. Protobuf Changes for QueryProfile to indicate if a query was run with a 'Limit wrap' a. UserBitShared.proto b. Java files (after # 3.a) c. C++ files (after # 3.a) 4. Server is able to detect the submitted autoLimit and apply the wrapper around the input SQL. For this, it evaluates SqlNode.getKind() and only wrapping with limit if it is a QUERY. If autoLimit is not applicable, remove the value to avoid incorrectly marking the profile during execution. 5. WebUI will render a pinned warning indicating that the result set size was limited. This should help explain two identical looking queries with different runtimes, because on of them ran with an implicit Limit Wrap 6. Queries can be resubmitted from their profile page, for which the optional limit is automatically enabled set to the value for the original profile. (That means a user does not have to remember to enable the limit wrap with the same value again, and can focus on the query instead) 7. The results page indicates if the number of records being rendered was auto-limited
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
