hrbrmstr commented on a change in pull request #1637: DRILL-7032: Ignore corrupt rows in a PCAP file URL: https://github.com/apache/drill/pull/1637#discussion_r255340198
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java ########## @@ -52,6 +52,7 @@ private int packetLength; protected int etherProtocol; protected int protocol; + protected boolean isCorrupt = false; Review comment: This was a brilliant idea! Ted's comment on the mailing list was spot-on and even just knowing which packet was "interesting" (in a bad/corrupt way) is super-helpful for identifying potentially malicious behavior. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
