cgivre commented on issue #1637: DRILL-7032: Ignore corrupt rows in a PCAP file URL: https://github.com/apache/drill/pull/1637#issuecomment-462139674 Thanks Bob! I’d really like to try this out with other corrupted PCAP files to see if it works properly. — C > On Feb 10, 2019, at 09:34, boB Rudis <[email protected]> wrote: > > @hrbrmstr commented on this pull request. > > In exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java <https://github.com/apache/drill/pull/1637#discussion_r255340198>: > > > @@ -52,6 +52,7 @@ > private int packetLength; > protected int etherProtocol; > protected int protocol; > + protected boolean isCorrupt = false; > This was a brilliant idea! Ted's comment on the mailing list was spot-on and even just knowing which packet was "interesting" (in a bad/corrupt way) is super-helpful for identifying potentially malicious behavior. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub <https://github.com/apache/drill/pull/1637#pullrequestreview-201906155>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFQfviEnwXyt5ewbB0BaKlGZP6DLbN_aks5vMC32gaJpZM4ay5jH>. >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
