sohami commented on a change in pull request #1626: DRILL-6855: Query from 
non-existent proxy user fails with "No default schema selected" when 
impersonation is enabled
URL: https://github.com/apache/drill/pull/1626#discussion_r256115976
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/calcite/jdbc/DynamicRootSchema.java
 ##########
 @@ -117,6 +119,14 @@ public void loadSchemaFactory(String schemaName, boolean 
caseSensitive) {
       }
     } catch(ExecutionSetupException | IOException ex) {
       logger.warn("Failed to load schema for \"" + schemaName + "\"!", ex);
+      // We can't proceed further without a schema, throw a runtime exception.
+      UserException.Builder exceptBuilder =
+          UserException
+              .resourceError(ex)
 
 Review comment:
   should be `executionError` instead of `resourceError`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to