gparai commented on a change in pull request #729: Drill 1328: Support table
statistics for Parquet
URL: https://github.com/apache/drill/pull/729#discussion_r257423804
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/NestedLoopJoinPrule.java
##########
@@ -84,8 +88,14 @@ public void onMatch(RelOptRuleCall call) {
if (!settings.isNestedLoopJoinEnabled()) {
return;
}
-
- final DrillJoinRel join = (DrillJoinRel) call.rel(0);
+ int[] joinFields = new int[2];
+ DrillJoinRel join = (DrillJoinRel) call.rel(0);
+ // If right outer join on simply equi join convert it to left outer join.
We only support left outer NLJ as of now
+ if (join.getJoinType() == JoinRelType.RIGHT
Review comment:
This change is what we wanted to do as part of DRILL-5214 since it is
unrelated to statistics. I will just close that JIRA as fixed once this goes in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
