vvysotskyi commented on a change in pull request #1608: DRILL-6960: AutoLimit the size of ResultSet for a WebUI (or REST) client URL: https://github.com/apache/drill/pull/1608#discussion_r258611205
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ########## @@ -76,6 +76,7 @@ private final SchemaTreeProvider schemaTreeProvider; /** Stores constants and their holders by type */ private final Map<String, Map<MinorType, ValueHolder>> constantValueHolderCache; + private Integer autoLimitRowCount; Review comment: Since the place outside of the class where this value is specified passes only `int` (taken from `RunQuery`), could you please replace `Integer` with `int` here, and in the places where null is set (the first constructor & `disableAutoLimit()` method) set 0. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
